Skip to content

fix: pass through copy_ casting operations#4269

Merged
lanluo-nvidia merged 1 commit into
mainfrom
push-lqrkyqkktykx
May 22, 2026
Merged

fix: pass through copy_ casting operations#4269
lanluo-nvidia merged 1 commit into
mainfrom
push-lqrkyqkktykx

Conversation

@narendasan
Copy link
Copy Markdown
Collaborator

Description

Fixes an issue with the copy_ converter not casting tensors

Fixes #4265

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@narendasan narendasan requested a review from lanluo-nvidia May 15, 2026 23:11
@meta-cla meta-cla Bot added the cla signed label May 15, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 15, 2026
@narendasan narendasan changed the title fix: copy_ does dtype casting now, so expand converter scope fix: pass through copy_ casting operations May 15, 2026
@github-actions github-actions Bot requested a review from apbose May 15, 2026 23:12
Copy link
Copy Markdown
Collaborator

@lanluo-nvidia lanluo-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lanluo-nvidia lanluo-nvidia merged commit ebe5493 into main May 22, 2026
87 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests needs-release-cherrypick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Exporting mixed precision copy and linear layer errors

2 participants